This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix disappearing exceptions in manhole. #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid sending syntax errors from the manhole to sentry.
Codecov Report
@@ Coverage Diff @@
## develop #5035 +/- ##
===========================================
- Coverage 61.58% 61.55% -0.03%
===========================================
Files 332 332
Lines 34216 34244 +28
Branches 5643 5644 +1
===========================================
+ Hits 21071 21078 +7
- Misses 11632 11650 +18
- Partials 1513 1516 +3 |
|
How was sentry intercepting this? I assume its not logging as sentry would just pass that on |
|
https://github.com/python/cpython/blob/v3.6.8/Lib/code.py#L128 normally sends the exception to this patch just removes the check on the exception hook. |
erikjohnston
approved these changes
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid sending syntax errors from the manhole to sentry.
Fixes #4768.